remove unneeded legacy tables #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orientationToSpriteTable is used to map the spawnId to the arbitrary sprite ID for the next piece. Reordering the sprites to match the game's piece ID order and reusing tetriminoTypeFromOrientation, this table can be removed. spawnOrientationFromOrientation may have been created in development when the RNG produced the orientation ID instead of the piece ID, but random spawn orientations weren't desired. As it's currently being used to convert the spawn ID to the same spawn ID, it can be removed. Reduces PRG usage by 38 bytes
Owner
|
awesome change! so this is only a change to sprite rendering? the order of the pieces in debug mode will remain the same, etc? |
Collaborator
Author
|
Yeah only the next piece sprites are affected, they've been placed in proper TJZOSLI order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orientationToSpriteTable is used to map the spawnId to the arbitrary sprite ID for the next piece. Reordering the sprites to match the game's piece ID order and reusing tetriminoTypeFromOrientation, this table can be removed.
spawnOrientationFromOrientation may have been created in development when the RNG produced the orientation ID instead of the piece ID, but random spawn orientations weren't desired. As it's currently being used to convert the spawn ID to the same spawn ID, it can be removed.
Reduces PRG usage by 38 bytes