Merged
Conversation
Collaborator
Author
|
Another thing to note – my |
parkerziegler
force-pushed
the
task/add-subject-tests
branch
from
6f5047a to
7cfbdfc
Compare
Collaborator
Author
|
@kitten Just rebased and force pushed this, should be good to go! |
kitten
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some basic tests for
makeSubject, based off bothcallbag-subjecttests and RxJS Subject tests. There's likely still some way to go, but I wanted to take an initial stab and at least see if I was grokking this concept correctly. Let me know what I can improve on @kitten, loving Wonka thus far!