Add pre-commit hook for bsrefmt. Run refmt over codebase.#15
Merged
kitten merged 1 commit into0no-co:masterfrom Apr 13, 2019
Merged
Add pre-commit hook for bsrefmt. Run refmt over codebase.#15kitten merged 1 commit into0no-co:masterfrom
kitten merged 1 commit into0no-co:masterfrom
Conversation
parkerziegler
force-pushed
the
task/add-refmt
branch
from
4be36ac to
b46218c
Compare
parkerziegler
commented
Apr 13, 2019
| "terser:cjs": "terser --config-file .terser.config.json -o ./dist/wonka.js ./dist/wonka.js", | ||
| "terser": "run-p terser:es terser:cjs", | ||
| "prettier": "prettier --write ./dist/*.js", | ||
| "refmt": "bsrefmt --in-place **/**/*.re", |
Collaborator
Author
There was a problem hiding this comment.
Providing a local script for users to run if they like.
kitten
approved these changes
Apr 13, 2019
Member
kitten
left a comment
kitten
left a comment
There was a problem hiding this comment.
I'm simply not a fan of some of their default choices but I suppose, like with gofmt, it's great! Previously there's been some bugs with some reformatting but afaik they're fixed so let's get this in for THE GREATER GOOD 😂
parkerziegler
commented
Apr 13, 2019
| "rimraf": "^2.6.3", | ||
| "terser": "^3.14.1" | ||
| }, | ||
| "lint-staged": { |
Collaborator
Author
There was a problem hiding this comment.
And our pre-commit setup.
Collaborator
Author
|
Dang I hadn't heard about the formatting drama. But thanks for merging it, I think it'll at least give us a standard pattern across editor setups (even if it's one we don't like). I'll work more on docs / tests this weekend! |
kitten
pushed a commit
that referenced
this pull request
Apr 14, 2019
This PR adds tests for some of the timing operators included in the `WonkaJs` module, specifically `delay`, `throttle`, `debounce`, and `sample`. Just chipping away at test coverage and having fun learning more `wonka` / observable-based programming 😅. It also adds `*.rei` files to our pre-commit hook and `yarn refmt` script, which I missed in #15 😞.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is purely a formatting PR. It adds a
yarn refmtscript that runs thebsrefmtCLI over the whole codebase, and ahuskypre-commit hook to do the same. There are no actual code changes included in this PR. @kitten the main motivation for this PR is just to getwonkato a state where it works withrefmtso the code is a bit more readable and so that we have nice editor integration with Jared'sreason-language-server. If you don't want to include this change, no worries. I've just found myself disabling editor settings when working onwonkatests previously so I didn't end up with a bunch of formatting changes in the diff. But since we have a formatter in Reason, we might as well use it!