fix(ProxyManager): Support overriding proxy definition of activateOnCreate

Author: floryst

Sources/Proxy/Core/ProxyManager/core.js

@@ -115,8 +115,9 @@ export default function addRegistrationAPI(publicAPI, model) {
       return null;
     }
     const definition = definitions[group][name];
+    const definitionOptions = Object.assign({}, definition.options, options);
     const proxy = definition.class.newInstance(
-      Object.assign({}, definition.options, options, {
+      Object.assign({}, definitionOptions, {
         proxyGroup: group,
         proxyName: name,
         proxyManager: publicAPI,
@@ -144,7 +145,7 @@ export default function addRegistrationAPI(publicAPI, model) {
 
     registerProxy(proxy);
 
-    if ((definition.options || {}).activateOnCreate) {
+    if (definitionOptions.activateOnCreate) {
       proxy.activate();
     }
 

Sources/Testing/testProxy.js

@@ -79,23 +79,17 @@ test('Proxy activation via config', (t) => {
 });
 
 test('Proxy activation via .activate()', (t) => {
-  const proxyManager = newProxyManager({
-    definitions: {
-      Sources: {
-        TrivialProducer: {
-          class: vtkTestProxyClass,
-          options: {},
-        },
-      },
-    },
-  });
+  const proxyManager = newProxyManager();
   t.equal(
     proxyManager.getActiveSource(),
     undefined,
     'No initial active source'
   );
 
-  const proxy = proxyManager.createProxy('Sources', 'TrivialProducer');
+  const proxy = proxyManager.createProxy('Sources', 'TrivialProducer', {
+    // Inhibit the default { activateOnCreate: true }
+    activateOnCreate: false,
+  });
   t.equal(
     proxyManager.getActiveSource(),
     undefined,