CASH-1101: Disable hover temporarily after detailed panel is triggered #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when users click a HoverLoanCard to expand the DetailedLoanCard, they will no longer page through loans on mouseover until they first interact with either the DetailedLoanCard or explicitly click on a neighboring card. Fixes: * Tapping on image in small hover card on mobile no longer triggers page redirection
ksekhri
commented
Jul 24, 2019
| }, | ||
| hoverCardLargeUpdateDetailedLoanIndex() { | ||
| if (!this.rowHasDetailedLoan) { | ||
| this.$emit('set-prevent-updating-detailed-card', true); |
There was a problem hiding this comment.
Interaction 1: User clicks on Image or Read more inside HoverLoanCardLarge
- This stops the mouseenter behavior of changing which loan is detailed
ksekhri
commented
Jul 24, 2019
| }, | ||
| handleMouseLeave() { | ||
| this.hoverLoanIndex = null; | ||
| this.setPreventUpdatingDetailedCard(false); |
There was a problem hiding this comment.
Interaction 2A: User exits the row (entering the DetailedLoanCard)
- This re-enables the mouseenter behavior
ksekhri
commented
Jul 24, 2019
| }, | ||
| hoverCardSmallUpdateDetailedLoanIndex() { | ||
| this.$emit('set-prevent-updating-detailed-card', false); | ||
| this.updateDetailedLoanIndex(); |
There was a problem hiding this comment.
Interaction 2B: User explicitly clicks on a neighboring loan
- This re-enables the mouseenter behavior
mcstover
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when users click a HoverLoanCard to expand the DetailedLoanCard, they will no longer page through loans on mouseover until they first interact with either the DetailedLoanCard or explicitly click on a neighboring card.
Note: This new behavior was QA'd by Adam. Tested on tablet/mobile.
Fixes: