Skip to content

Commit 5f0b46b

Browse files
committed
Remove redundant veriable definition from recipes
- Some of the variables like call_hostpython_via_targetpython, install_in_hostpython are redifined in the package recipes with the exact same value as its parent class, making the definitions redundant. This patch removes this redefinitions.
1 parent 436d5a9 commit 5f0b46b

File tree

8 files changed

+0
-14
lines changed

8 files changed

+0
-14
lines changed

pythonforandroid/recipes/aiohttp/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ class AIOHTTPRecipe(CppCompiledComponentsPythonRecipe): # type: ignore # pylint
88
url = "https://pypi.python.org/packages/source/a/aiohttp/aiohttp-{version}.tar.gz"
99
name = "aiohttp"
1010
depends: List[str] = ["setuptools"]
11-
call_hostpython_via_targetpython = False
1211
install_in_hostpython = True
1312

1413
def get_recipe_env(self, arch):

pythonforandroid/recipes/flask/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ class FlaskRecipe(PythonRecipe):
1111
python_depends = ['jinja2', 'werkzeug', 'markupsafe', 'itsdangerous', 'click']
1212

1313
call_hostpython_via_targetpython = False
14-
install_in_hostpython = False
1514

1615

1716
recipe = FlaskRecipe()

pythonforandroid/recipes/pandas/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ class PandasRecipe(CppCompiledComponentsPythonRecipe):
1212
python_depends = ['python-dateutil', 'pytz']
1313
patches = ['fix_numpy_includes.patch']
1414

15-
call_hostpython_via_targetpython = False
16-
need_stl_shared = True
17-
1815
def get_recipe_env(self, arch):
1916
env = super().get_recipe_env(arch)
2017
# we need the includes from our installed numpy at site packages

pythonforandroid/recipes/protobuf_cpp/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ class ProtobufCppRecipe(CppCompiledComponentsPythonRecipe):
1818
name = 'protobuf_cpp'
1919
version = '3.6.1'
2020
url = 'https://github.com/google/protobuf/releases/download/v{version}/protobuf-python-{version}.tar.gz'
21-
call_hostpython_via_targetpython = False
2221
depends = ['cffi', 'setuptools']
2322
site_packages_name = 'google/protobuf/pyext'
2423
setup_extra_args = ['--cpp_implementation']

pythonforandroid/recipes/pygame/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ class Pygame2Recipe(CompiledComponentsPythonRecipe):
2121

2222
depends = ['sdl2', 'sdl2_image', 'sdl2_mixer', 'sdl2_ttf', 'setuptools', 'jpeg', 'png']
2323
call_hostpython_via_targetpython = False # Due to setuptools
24-
install_in_hostpython = False
2524

2625
def prebuild_arch(self, arch):
2726
super().prebuild_arch(arch)

pythonforandroid/recipes/secp256k1/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ class Secp256k1Recipe(CppCompiledComponentsPythonRecipe):
77
version = '0.13.2.4'
88
url = 'https://github.com/ludbb/secp256k1-py/archive/{version}.tar.gz'
99

10-
call_hostpython_via_targetpython = False
11-
1210
depends = [
1311
'openssl',
1412
'hostpython3',

pythonforandroid/recipes/sympy/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ class SympyRecipe(PythonRecipe):
88

99
depends = ['mpmath']
1010

11-
call_hostpython_via_targetpython = True
12-
1311
patches = ['fix_timeutils.patch', 'fix_pretty_print.patch']
1412

1513

pythonforandroid/recipes/twisted/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ class TwistedRecipe(CythonRecipe):
1111
depends = ['setuptools', 'zope_interface', 'incremental', 'constantly']
1212
patches = ['incremental.patch', 'remove_tests.patch']
1313

14-
call_hostpython_via_targetpython = False
15-
install_in_hostpython = False
16-
1714
def prebuild_arch(self, arch):
1815
super().prebuild_arch(arch)
1916
# TODO Need to whitelist tty.pyo and termios.so here

0 commit comments

Comments
 (0)