Skip to content

Added the localization#537

Merged
kelson42 merged 20 commits into
kiwix:mainfrom
tvision251:feature/24-localization
Nov 22, 2023
Merged

Added the localization#537
kelson42 merged 20 commits into
kiwix:mainfrom
tvision251:feature/24-localization

Conversation

@tvision251
Copy link
Copy Markdown
Contributor

@tvision251 tvision251 commented Nov 14, 2023

Fixes #24

@kelson42
Copy link
Copy Markdown
Contributor

@tvision251 Thank you, please secure Codefactor is green.

@kelson42
Copy link
Copy Markdown
Contributor

kelson42 commented Nov 14, 2023

@translatewiki @Nikerabbit would the strings like they are here defined, something you could import and export with translatewiki bot?

@tvision251
Copy link
Copy Markdown
Contributor Author

@tvision251 Thank you, please secure Codefactor is green.

It's done

@tvision251
Copy link
Copy Markdown
Contributor Author

@translatewiki @Nikerabbit would the strings like they are here defined, something you could import and export with translatewiki bot?

We can update the following strings for other languages(The left side represents the key and the right one is the value).
https://github.com/kiwix/apple/blob/a5bc9053f508612a03ac8cb1d4f02e78e7016686/Support/en.lproj/Localizable.strings

Here is the empty file for Spanish(example).
https://github.com/kiwix/apple/blob/a5bc9053f508612a03ac8cb1d4f02e78e7016686/Support/es.lproj/Localizable.strings

i.e.

/* Library Refresh Error */
"Error retrieving library data." = "Error al recuperar los datos de la biblioteca.";

...

"Download Completed" = "Descarga completa";

@Nikerabbit
Copy link
Copy Markdown

Yes, the .strings format should be supported.

@kelson42
Copy link
Copy Markdown
Contributor

@tvision251 It seems your last commit has broken again Codefactor part of the CI

@tvision251
Copy link
Copy Markdown
Contributor Author

@tvision251 It seems your last commit has broken again Codefactor part of the CI

fixed

@kelson42 kelson42 force-pushed the feature/24-localization branch from 4df733a to d651462 Compare November 17, 2023 05:34
@kelson42
Copy link
Copy Markdown
Contributor

@automactic I would like to merge this one in prioriy as this is mostly a no-brainer and would allow TW community to start to work on translations quickly.

@kelson42 kelson42 force-pushed the feature/24-localization branch from d651462 to b3ee97f Compare November 17, 2023 16:35
@kelson42
Copy link
Copy Markdown
Contributor

Rebased on main to benefit of the new CI

@kelson42 kelson42 force-pushed the feature/24-localization branch from b3ee97f to 095a6ba Compare November 19, 2023 16:41
@kelson42
Copy link
Copy Markdown
Contributor

@BPerlakiH Could you please review this PR?

Comment thread Views/ViewModifiers/ExternalLinkHandler.swift Outdated
BPerlakiH
BPerlakiH previously approved these changes Nov 20, 2023
@tvision251 tvision251 force-pushed the feature/24-localization branch from 419c551 to 2c9f8d8 Compare November 21, 2023 22:50
@kelson42 kelson42 merged commit 5285e17 into kiwix:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Localization

4 participants