-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Generated suffix to OpenAPI generated code #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure serviceSuffix and modelSuffix in OpenAPI tools to clearly mark auto-generated Angular services and models with 'Generated' suffix for better code clarity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update check-api-changes job to also detect changes to openapitools.json and frontend/package.json. This ensures API code is regenerated when generator configuration or npm scripts are modified, not just when the OpenAPI spec changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add separate logic for pull_request events to properly detect changes to API spec and config files by comparing against the base branch. This ensures openapitools.json and package.json changes trigger API regeneration in PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update generate-api npm script to include serviceSuffix and modelSuffix parameters. This will generate API code with 'Generated' suffix (e.g., TasksGenerated, TaskGenerated) to clearly mark auto-generated files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update ngVersion from 20.0.0 to 21.0.0 in both openapitools.json and package.json to match the Angular v21 upgrade. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update serviceSuffix and modelSuffix from 'Generated' to 'Gen' for more concise naming (e.g., TasksGen, TaskGen instead of TasksGenerated, TaskGenerated). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update build-backend and build-frontend jobs to depend on generate-api instead of check-api-changes. This ensures builds wait for API code generation to complete before running, preventing build failures due to outdated generated code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update all application code to use the new Gen suffix for generated API types (TaskGen, TasksGen, TaskCreateGen, TaskUpdateGen) instead of the old names without suffix. Changes: - task-form.ts: Update imports and type references - task-list.ts: Update imports and type references - task-resource-store.ts: Update imports and type references 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update serviceSuffix from 'Gen' to 'ServiceGen' so services are named TasksServiceGen instead of TasksGen. Models keep the 'Gen' suffix (TaskGen, TaskCreateGen, etc). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Change modelSuffix from 'Gen' to 'ModelGen' to make model types more explicit. This results in: - Services: TasksServiceGen - Models: TaskModelGen, TaskCreateModelGen, TaskUpdateModelGen Updated all application code to use the new naming convention. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure serviceSuffix and modelSuffix in OpenAPI tools to clearly mark auto-generated Angular services and models with 'Generated' suffix for better code clarity.
🤖 Generated with Claude Code