fix(json-api-nestjs): use ErrorFormatService for format error in AtomicOperationModule fix work with tmpId

Author: klerick

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/atomic-operation.module.ts

@@ -19,6 +19,7 @@ import {
   AsyncIterate,
 } from './factory';
 import { MAP_CONTROLLER_INTERCEPTORS } from './constants';
+import { ErrorFormatService } from '../../modules/mixin/service';
 
 @Module({})
 export class AtomicOperationModule implements NestModule {
@@ -48,10 +49,16 @@ export class AtomicOperationModule implements NestModule {
     entityModules: DynamicModule[],
     commonModule: DynamicModule
   ): DynamicModule {
+
+    const errorFormat = (commonModule.providers || []).find(i => 'provide' in i && i.provide === ErrorFormatService )
+    if (!errorFormat) {
+      throw new Error('ErrorFormatService not found, should be provide in common orm module')
+    }
     return {
       module: AtomicOperationModule,
       controllers: [OperationController],
       providers: [
+        errorFormat,
         ExplorerService,
         ExecuteService,
         SwaggerService,
@@ -87,3 +94,5 @@ export class AtomicOperationModule implements NestModule {
       .forRoutes('{*splat}');
   }
 }
+
+

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/controllers/operation.controller.spec.ts

@@ -25,6 +25,7 @@ import {
 import { OperationMethode } from '../types';
 import { AsyncLocalStorage } from 'async_hooks';
 import { RUN_IN_TRANSACTION_FUNCTION } from '../../../constants';
+import { ErrorFormatService } from '@klerick/json-api-nestjs';
 
 describe('OperationController', () => {
   let operationController: OperationController;
@@ -66,6 +67,10 @@ describe('OperationController', () => {
           provide: AsyncLocalStorage,
           useValue: new AsyncLocalStorage(),
         },
+        {
+          provide: ErrorFormatService,
+          useValue: {}
+        }
       ],
     }).compile();
 

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/service/execute.service.spec.ts

@@ -19,6 +19,7 @@ import { ParamsForExecute } from '../types';
 import { AsyncLocalStorage } from 'async_hooks';
 import { RUN_IN_TRANSACTION_FUNCTION } from '../../../constants';
 import { Mock } from 'vitest';
+import { ErrorFormatService } from '../../mixin/service';
 
 describe('ExecuteService', () => {
   let service: ExecuteService;
@@ -54,6 +55,10 @@ describe('ExecuteService', () => {
           provide: AsyncLocalStorage,
           useValue: new AsyncLocalStorage(),
         },
+        {
+          provide: ErrorFormatService,
+          useValue: {}
+        }
       ],
     }).compile();
 

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/service/execute.service.ts

@@ -5,6 +5,7 @@ import {
   Injectable,
   PipeTransform,
   Type,
+  InternalServerErrorException,
 } from '@nestjs/common';
 import {
   INTERCEPTORS_METADATA,
@@ -36,6 +37,7 @@ import { IterateFactory } from '../factory';
 import { TypeFromType, ValidateQueryError } from '../../../types';
 import { RunInTransaction } from '../../mixin/types';
 import { RUN_IN_TRANSACTION_FUNCTION } from '../../../constants';
+import { ErrorFormatService } from '../../mixin/service';
 
 export function isZodError(
   param: string | unknown
@@ -70,6 +72,7 @@ export class ExecuteService {
   private mapControllerInterceptor!: MapControllerInterceptor;
 
   @Inject(AsyncLocalStorage) private asyncLocalStorage!: AsyncLocalStorage<any>;
+  @Inject(ErrorFormatService) private errorFormatService!: ErrorFormatService;
 
   private _interceptorsContextCreator!: InterceptorsContextCreator;
 
@@ -116,8 +119,8 @@ export class ExecuteService {
 
         const itemReplace = this.replaceTmpIds(paramsForExecute, tmpIdsMap);
         const body = itemReplace.at(-1);
-        const currentTmpId = tmpIds[i];
-
+        // First operation doesn't have tmpId'
+        const currentTmpId = i !== 0 ? tmpIds[i] : undefined;
         if (methodName === 'postOne' && currentTmpId && body) {
           if (typeof body === 'object' && 'attributes' in body) {
             body['id'] = `${currentTmpId}`;
@@ -293,7 +296,20 @@ export class ExecuteService {
       }
       throw new HttpException(response, e.getStatus());
     }
-    throw e;
+    const formatError = this.errorFormatService.formatError(e);
+
+    if (formatError instanceof InternalServerErrorException) {
+      throw formatError
+    }
+    const response = formatError.getResponse()
+    if (typeof response === 'object' && 'message' in response && Array.isArray(response['message'])) {
+      response['message'] = response['message'].map((m: any) => {
+        m['path'] = [KEY_MAIN_INPUT_SCHEMA, `${i}`, ...m['path']];
+        return m;
+      });
+      throw new HttpException(response, formatError.getStatus());
+    }
+    throw formatError;
   }
 
   private async runOneOperation(

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/service/explorer.service.spec.ts

@@ -57,11 +57,16 @@ describe('ExplorerService', () => {
   });
 
   describe('getMethodNameByParam()', () => {
-    it('should return the correct method name for given parameters', () => {
+    it('should return the correct method name for given parameters: postRelationship', () => {
       expect(service.getMethodNameByParam(Operation.add, 'id', 'rel')).toBe(
         'postRelationship'
       );
     });
+    it('should return the correct method name for given parameters: postOne', () => {
+      expect(service.getMethodNameByParam(Operation.add, 'id')).toBe(
+        'postOne'
+      );
+    });
   });
 
   describe('getParamsForMethod()', () => {

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/service/explorer.service.ts

@@ -48,7 +48,7 @@ export class ExplorerService<E extends object = object> {
   ): OperationMethode<E> {
     switch (operation) {
       case Operation.add:
-        return id ? 'postRelationship' : 'postOne';
+        return rel ? 'postRelationship' : 'postOne';
       case Operation.remove:
         return rel ? 'deleteRelationship' : 'deleteOne';
       case Operation.update:

libs/json-api/json-api-nestjs/src/lib/modules/atomic-operation/utils/zod/zod-helper.ts

@@ -36,6 +36,7 @@ export const zodAdd = <T extends string>(type: T) =>
         .object({
           type: z.literal(type),
           tmpId: z.union([z.number(), z.string()]).optional(),
+          id: z.string().optional(),
         })
         .strict(),
       data: zodGeneralData,