feat(json-api-nestjs-typeorm): refine type usage, update imports, and handle relation aliases consistently

Author: klerick

libs/json-api/json-api-nestjs-typeorm/src/lib/orm-methods/get-all/get-all.ts

@@ -1,7 +1,7 @@
 import { Query, ASC, DESC } from '@klerick/json-api-nestjs';
 import { ObjectTyped, ResourceObject } from '@klerick/json-api-nestjs-shared';
 
-import { TypeOrmService } from '../../service';
+import { RelationAlias, TypeOrmService } from '../../service';
 
 import {
   ALIAS_FOR_PAGINATION,
@@ -173,17 +173,17 @@ export async function getAll<E extends object, IdKey extends string = 'id'>(
   }
   if (include) {
     for (const rel of include) {
-      includeRel.add(rel);
+      includeRel.add(`${rel}`);
     }
   }
   const fieldsCast = fields as Query<Record<string, any>, IdKey>['fields'];
   if (fieldsCast) {
     if (include) {
       for (const rel of include) {
         const currentIncludeAlias =
-          this.typeormUtilsService.getAliasForRelation(rel);
+          this.typeormUtilsService.getAliasForRelation(rel as keyof RelationAlias<E>);
         const primaryColumnName =
-          this.typeormUtilsService.getPrimaryColumnForRel(rel);
+          this.typeormUtilsService.getPrimaryColumnForRel(rel as keyof RelationAlias<E>);
         selectFields.add(`${currentIncludeAlias}.${primaryColumnName}`);
       }
     }

libs/json-api/json-api-nestjs-typeorm/src/lib/orm-methods/get-one/get-one.ts

@@ -1,7 +1,7 @@
 import { NotFoundException } from '@nestjs/common';
 import { ValidateQueryError, QueryOne } from '@klerick/json-api-nestjs';
 import { ObjectTyped, ResourceObject } from '@klerick/json-api-nestjs-shared';
-import { TypeOrmService } from '../../service';
+import { RelationAlias, TypeOrmService } from '../../service';
 
 export async function getOne<E extends object, IdKey extends string>(
   this: TypeOrmService<E, IdKey>,
@@ -34,7 +34,7 @@ export async function getOne<E extends object, IdKey extends string>(
           selectFields.add(
             this.typeormUtilsService.getAliasPath(
               itemFieldRel,
-              this.typeormUtilsService.getAliasForRelation(rel as any)
+              this.typeormUtilsService.getAliasForRelation(rel as keyof RelationAlias<E>)
             )
           );
         }
@@ -43,7 +43,8 @@ export async function getOne<E extends object, IdKey extends string>(
   }
 
   if (include) {
-    for (const rel of include) {
+    for (const relFromLoop of include) {
+      const rel = relFromLoop as keyof RelationAlias<E>
       const currentIncludeAlias =
         this.typeormUtilsService.getAliasForRelation(rel);
 

libs/json-api/json-api-nestjs-typeorm/src/lib/service/typeorm-utils.service.ts

@@ -10,8 +10,6 @@ import {
   Equal,
   In,
   Repository,
-  ILike,
-  FindOperator,
 } from 'typeorm';
 import { RelationMetadata as TypeOrmRelationMetadata } from 'typeorm/metadata/RelationMetadata';
 import {
@@ -40,7 +38,7 @@ import {
 import { CURRENT_ENTITY_REPOSITORY } from '../constants';
 import { DriverUtils } from 'typeorm/driver/DriverUtils';
 
-type RelationAlias<E> = {
+export type RelationAlias<E> = {
   [K in UnionToTuple<RelationKeys<E>>[number] & PropertyKey]: string;
 };
 type RelationMetadata<E> = {