-
Notifications
You must be signed in to change notification settings - Fork 132
add the design of kmesh support workload model #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The diagram is too complex. If it involves multiple processes, please split it into multiple diagrams.
- pls add
picsdir to store pictures. - keep the Chinese/English style.
| } | ||
| ``` | ||
|
|
||
| ## How kmesh subscribe and use the workload model info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the workload model, there are also related processes such as authentication and TLS, which do not seem to be mentioned in the current design. If it is just a basic process design for now, please specify this in the documentation.
|
|
||
| ## Subscription data process flow | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the design diagrams, please provide a detailed description of the processing logic for each step in the entire workflow, including any potential constraints and limitations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a svg, so we may edit it in future
|
|
||
|  | ||
|
|
||
| In the subsequent traffic management of kmesh, based on the IP and Port accessed by the client, find the corresponding service and its endpoints from the BPF map, and then randomly select an endpoint to forward the request to that endpoint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randonly select an endpoint is just current behavior, we should support more LB algorithms
| // service map | ||
| typedef struct | ||
| { | ||
| __u32 service_id; // service id, through <namespace>/<hostname> string convert to uint32 variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the diff with L82
| { | ||
| __be32 ipv4; // backend ip | ||
| __u32 port_count; | ||
| port_pair portlist[MAX_COUNT]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MAX_COUNT a const?
|
@kwb0523 any update |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.