Skip to content

Conversation

@kwb0523
Copy link
Contributor

@kwb0523 kwb0523 commented Jan 19, 2024

No description provided.

Copy link
Contributor

@nlgwcy nlgwcy Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The diagram is too complex. If it involves multiple processes, please split it into multiple diagrams.
  2. pls add pics dir to store pictures.
  3. keep the Chinese/English style.

}
```

## How kmesh subscribe and use the workload model info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the workload model, there are also related processes such as authentication and TLS, which do not seem to be mentioned in the current design. If it is just a basic process design for now, please specify this in the documentation.


## Subscription data process flow

![workload info operation](./workload_info_operation.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the design diagrams, please provide a detailed description of the processing logic for each step in the entire workflow, including any potential constraints and limitations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a svg, so we may edit it in future


![kmesh subscribe workload](./kmesh_subscribe_workload.png)

In the subsequent traffic management of kmesh, based on the IP and Port accessed by the client, find the corresponding service and its endpoints from the BPF map, and then randomly select an endpoint to forward the request to that endpoint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randonly select an endpoint is just current behavior, we should support more LB algorithms

// service map
typedef struct
{
__u32 service_id; // service id, through <namespace>/<hostname> string convert to uint32 variable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the diff with L82

{
__be32 ipv4; // backend ip
__u32 port_count;
port_pair portlist[MAX_COUNT];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MAX_COUNT a const?

@hzxuzhonghu
Copy link
Member

@kwb0523 any update

@nlgwcy
Copy link
Contributor

nlgwcy commented Feb 8, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 6f90963 into kmesh-net:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants