Skip to content

Conversation

@adity1raut
Copy link

Pull Request Description

Summary

This PR Fixed #252 updates the Docusaurus configuration to replace the hardcoded Google Analytics tracking ID with an environment variable. This improves security and prevents committing analytics IDs directly to source control.

Changes Included

  • Removed hardcoded GA tracking ID from docusaurus.config.js
  • Added support for environment variable GA_TRACKING_ID
  • Updated GitHub Actions workflow to pass the secret value during build

Modified Configuration Example

trackingID: process.env.GA_TRACKING_ID,

GitHub Actions Update

env:
  GA_TRACKING_ID: ${{ secrets.GA_TRACKING_ID }}

Signed-off-by: adity1raut <araut7798@gmail.com>
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for kmesh-net failed.

Name Link
🔨 Latest commit 61afce7
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/691afd6e199f4a00080bcd2b

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot
Copy link
Collaborator

Welcome @adity1raut! It looks like this is your first PR to kmesh-net/website 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @adity1raut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture and maintainability of the Docusaurus website by refactoring the Google Analytics tracking ID implementation. Instead of hardcoding this sensitive identifier directly into the configuration, it now leverages environment variables, ensuring that the ID is managed externally and securely, particularly in CI/CD pipelines, and preventing its exposure in public repositories.

Highlights

  • Google Analytics Tracking ID Externalization: The hardcoded Google Analytics tracking ID in docusaurus.config.js has been replaced with an environment variable (process.env.GA_TRACKING_ID) to improve security and prevent sensitive data from being committed to source control.
  • dotenv Integration: The dotenv package has been introduced and configured in docusaurus.config.js to enable loading environment variables from a .env file during development.
  • Environment File Management: A new .env.example file has been added to provide a template for the GA_TRACKING_ID, and .env has been added to .gitignore to ensure local environment files are not inadvertently committed.
  • CI/CD Integration (GitHub Actions): The pull request description indicates that the GitHub Actions workflow will be updated to securely pass the GA_TRACKING_ID as a secret during the build process, although the workflow file itself is not part of this patch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the hardcoded Google Analytics tracking ID with an environment variable, which is a significant improvement for security and configuration management. The changes are well-executed, including adding .env to the .gitignore file and updating the necessary dependencies. I have one suggestion for the .env.example file to prevent potential misuse of the example tracking ID.

@@ -0,0 +1 @@
GA_TRACKING_ID = "G-854W8PEZ1Z" No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's great that you've added an example environment file. However, using a real-looking tracking ID like G-854W8PEZ1Z could lead to developers accidentally using it in their local or even production environments if they copy the file without modification. This could pollute the analytics data. It's better practice to use a placeholder value to make it clear that it needs to be replaced.

GA_TRACKING_ID="G-XXXXXXXXXX"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded Google Analytics Tracking ID

2 participants