Skip to content

Commit 5294dba

Browse files
committed
Addressed review comments
1 parent 5c504a1 commit 5294dba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/eventing/features/authorization.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ spec:
7575
7676
### Specify for who the `EventPolicy` applies
7777

78-
The `.spec.to` section specifies **where** the events are allowed to be sent. This field is optional; if left empty, the policy applies to all resources within the namespace.
78+
The `.spec.to` section specifies **where** the events are allowed to be sent. This field is optional; if left empty, the policy applies to all resources within the namespace. By specifying multiple targets in `.spec.to`, the `EventPolicies` scope gets widened by applying the same rules to multiple targets.
7979

8080
There are two ways to define these targets:
8181

@@ -123,7 +123,7 @@ The `.spec.from` section specifies **who** is allowed to send events to the targ
123123

124124
2. `from.sub`:
125125

126-
* **Definition**: Specifies a subject, such as a service account, that is allowed to send events. It can include wildcard patterns as a postfix (`*`) for broader matching.
126+
* **Definition**: Specifies a subject (a service account name), that is allowed to send events. It can include wildcard patterns as a postfix (`*`) for broader matching.
127127
* **Example**: The `EventPolicy` allows events from the `trusted-app` service account in the default namespace and any service account in `default` namespace that starts with `other-`.
128128
* **Use Case**: Use `from.sub` to allow specific users or service accounts, or to apply wildcard patterns for more flexibility.
129129
```yaml
@@ -261,7 +261,7 @@ spec:
261261
namespace: namespace-1
262262
```
263263

264-
For debugging we also create an event-display service and Trigger:
264+
For debugging we also create an event-display Kservice and Trigger:
265265

266266
```yaml
267267
apiVersion: serving.knative.dev/v1
@@ -376,7 +376,7 @@ status:
376376
name: event-policy
377377
```
378378

379-
And in the event-display, you should see only events from `pingsource-2` anymore:
379+
And in the event-display, you should see only events from `pingsource-2` anymore, as we referenced this in our EventPolicy `event-policy` to be allowed to send events to Broker `broker`:
380380

381381
```
382382
$ kubectl -n namespace-1 logs event-display-00001-deployment-56cd8dd644-64xl2
@@ -437,7 +437,7 @@ status:
437437
type: Ready
438438
```
439439

440-
And we should see only events from `pingsource-1` in the event-display (as `pingsource-1` is in the same namespace as `broker`):
440+
And we should see only events from `pingsource-1` in the event-display, as `pingsource-1` is in the same namespace as `broker`:
441441

442442
```
443443
$ kubectl -n namespace-1 logs event-display-00001-deployment-56cd8dd644-64xl2

0 commit comments

Comments
 (0)