Skip to content

bad links/missing files in pubsub eventing example #1264

@amygdala

Description

@amygdala

The 'verify' section of https://github.com/knative/docs/tree/release-0.5/docs/eventing/samples/gcp-pubsub-source#verify as well as https://github.com/knative/docs/tree/master/docs/eventing/samples/gcp-pubsub-source has some issues.

In the 0.5 version, the readme says:

We will verify that the published message was sent into the Knative eventing system by looking at what is downstream of the GcpPubSubSource. If you deployed the Subscriber, then continue using this section. If not, then you will need to look downstream yourself.

However, the link is bad: there's no Subscriber section.

In the master version, the text is:

The function and the subscription were created by applying the subscriber.yaml manifest in the deployment section above.

However, there's no subscriber.yaml (as far as I can tell ..)

[This example appeared to deploy okay for me, but AFAICT is not actually working in the sense of responding to new pubsub data... haven't dug into it yet but given the above I'm wondering if stuff is missing].

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions