-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
kind/metaDocumentation about the repo -- contributor roles, issue templates, etc.Documentation about the repo -- contributor roles, issue templates, etc.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/nice-to-have
Milestone
Description
Describe the change you'd like to see
Adding files to the hello-world samples requires a special test configuration step. This is not currently documented or made clear in the test output.
Document how to add new files to the hello-world samples:
- Contributing guide details that explain adding or removing files from an existing sample
- More actionable error messages in the test failure report that points to the instructions on the action to take
Additional context
Per the discussion about sample CI testing in #1774, all files which are copied to test the build must be added to a test configuration file at test/sampleapp/config.yaml.
From my understanding, this is to enable:
- Verify that all required files continue to be present in a given PR
- A superset list of the files which are checked for synchronization with the README
@chaodaiG for awareness
Metadata
Metadata
Assignees
Labels
kind/metaDocumentation about the repo -- contributor roles, issue templates, etc.Documentation about the repo -- contributor roles, issue templates, etc.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/nice-to-have