-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Expected Behavior
Instructions here for stackdriver https://github.com/knative/docs/blob/master/serving/installing-logging-metrics-traces.md#stackdriver should reference a stackdriver file or directory.
kubectl apply --recursive --filename config/monitoring/100-namespace.yaml \
--filename third_party/config/monitoring/logging/stackdriver
Actual Behavior
Checking out v0.3.0 as instructed (also checked v0.4.0) third_party/config/monitoring/logging/stackdriver is not to be found
Steps to Reproduce the Problem
kubectl apply --recursive --filename config/monitoring/100-namespace.yaml \
--filename third_party/config/monitoring/logging/stackdriver
It won't apply the second file.
Additional Info
I did find stackdriver yamls in config/monitoring/logging/stackdriver and config/monitoring/metrics/stackdriver
I applied these, but not overly sure it is working at present. If someone can confirm this just needs correcting to...
kubectl apply --recursive --filename config/monitoring/100-namespace.yaml \
--filename config/monitoring/logging/stackdriver
...I will make a PR
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.