Skip to content

Conversation

@Harwayne
Copy link
Contributor

Part of #1021

Proposed Changes

  • Switches the sample from using Channel to use Broker.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 21, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2019
@Harwayne Harwayne marked this pull request as ready for review March 26, 2019 21:48
@Harwayne
Copy link
Contributor Author

/assign @samodell

@Harwayne
Copy link
Contributor Author

Harwayne commented Apr 1, 2019

Ping.

Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3353747 into knative:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants