Skip to content

Update the kubernetes-event-source example to use Broker, rather than Channel. #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2019
Merged

Update the kubernetes-event-source example to use Broker, rather than Channel. #1091

merged 5 commits into from
Apr 1, 2019

Conversation

@Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Mar 26, 2019 •
edited
Loading

Part of #1021

Proposed Changes

  • Switches the sample from using Channel to use Broker.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2019
@Harwayne Harwayne marked this pull request as ready for review March 27, 2019 19:31
@Harwayne
Copy link
Contributor Author

Harwayne commented Mar 27, 2019

/assign @samodell

@Harwayne
Copy link
Contributor Author

Harwayne commented Apr 1, 2019

Ping.

samodell
samodell suggested changes Apr 1, 2019
View reviewed changes
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor

samodell commented Apr 1, 2019

/lgtm

@knative-prow-robot knative-prow-robot added approved lgtm Indicates that a PR is ready to be merged. labels Apr 1, 2019
@samodell samodell added this to the v0.5 Docs milestone Apr 1, 2019
@knative-prow-robot knative-prow-robot merged commit 24be444 into knative:master Apr 1, 2019
@toshi0607 toshi0607 mentioned this pull request Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

1 more reviewer

@samodell samodell samodell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5 Docs

Development

Successfully merging this pull request may close these issues.

4 participants

@Harwayne @knative-prow-robot @samodell @googlebot