Skip to content

Conversation

@Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Mar 27, 2019

Part of #1021

Proposed Changes

  • Update the iot-core demo to use Broker rather than Channel
  • Removes ko and kail usage.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 27, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2019
@Harwayne
Copy link
Contributor Author

/assign @samodell

@Harwayne
Copy link
Contributor Author

Harwayne commented Apr 1, 2019

Ping.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2019
Co-Authored-By: Harwayne <harwayne@google.com>
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor

samodell commented Apr 1, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
@samodell samodell added this to the v0.5 Docs milestone Apr 1, 2019
@knative-prow-robot knative-prow-robot merged commit 88f3afb into knative:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants