Update sample to use the new URL field #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the blue green sample to use the new URL field instead of asking the user to query a fixed URL. Fixes knative#1078
knative-prow-robot
added
the
size/S
sebgoa
reviewed
Mar 31, 2019
samodell
suggested changes
Apr 1, 2019
Co-Authored-By: dgerd <dangerd@google.com>
Co-Authored-By: dgerd <dangerd@google.com>
Contributor
|
/lgtm |
samodell
approved these changes
Apr 5, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test pull-knative-docs-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the blue green sample to use the new URL field instead of
asking the user to query a fixed URL.
Fixes #1078