Skip to content

Fix 'verion' mispelling in check-install-version #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix 'verion' mispelling in check-install-version #1122

merged 1 commit into from
Apr 1, 2019

Conversation

@nebelsprachen
Copy link
Contributor

@nebelsprachen nebelsprachen commented Mar 31, 2019 •
edited
Loading

Relates to Issue #1119

Fixes #(1119 )

Proposed Changes

  • 'verion' typo fix
  • removed unnecessary article 'a' in line 33

@nebelsprachen
Fix 'verion' mispelling in check-install-version
b9a3608 
Relates to [Issue knative#1119](knative#1119)
* 'verion' typo fix
* removed unnecessary article 'a' in line 33
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 31, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2019
@nebelsprachen
Copy link
Contributor Author

nebelsprachen commented Mar 31, 2019

/assign @samodell

@nebelsprachen
Copy link
Contributor Author

nebelsprachen commented Mar 31, 2019

/assign @vaikas-google

@samodell
Copy link
Contributor

samodell commented Mar 31, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaedwar, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nebelsprachen
Copy link
Contributor Author

nebelsprachen commented Apr 1, 2019

/retest

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 1, 2019

@joaedwar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vaikas
Copy link
Contributor

vaikas commented Apr 1, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2019
@nebelsprachen
Copy link
Contributor Author

nebelsprachen commented Apr 1, 2019

/retest

@samodell
Copy link
Contributor

samodell commented Apr 1, 2019

@chaodaiG Any idea why the docs-integration-tests are failing here? I'm seeing this in the error logs:

I0401 16:11:28.804] Test subprocess exited with code 1
I0401 16:11:50.832] ERROR: (gcloud.compute.target-pools.list) Some requests did not succeed:
I0401 16:11:50.833]  - Required 'compute.targetPools.list' permission for 'projects/knative-tests'
I0401 16:11:50.833] 
I0401 16:12:12.552] ERROR: (gcloud.compute.target-pools.list) Some requests did not succeed:
I0401 16:12:12.553]  - Required 'compute.targetPools.list' permission for 'projects/knative-tests'
I0401 16:12:12.553] 
I0401 16:12:12.636] Artifacts were written to /workspace/_artifacts
I0401 16:12:12.636] Test result code is 1
I0401 16:12:12.639] ==================================
I0401 16:12:12.640] ==== INTEGRATION TESTS FAILED ====
I0401 16:12:12.640] ==================================
W0401 16:12:12.669] Run: ('/workspace/./test-infra/jenkins/../scenarios/../hack/coalesce.py',)
E0401 16:12:12.669] Command failed
I0401 16:12:12.669] process 635 exited with code 1 after 0.9m
E0401 16:12:12.669] FAIL: pull-knative-docs-integration-tests
I0401 16:12:12.670] Call:  gcloud auth activate-service-account --key-file=/etc/test-account/service-account.json
W0401 16:12:13.117] Activated service account credentials for: [prow-job@knative-tests.iam.gserviceaccount.com]
I0401 16:12:13.177] process 848 exited with code 0 after 0.0m
I0401 16:12:13.178] Call:  gcloud config get-value account
I0401 16:12:13.498] process 860 exited with code 0 after 0.0m
I0401 16:12:13.498] Will upload results to gs://knative-prow/pr-logs using prow-job@knative-tests.iam.gserviceaccount.com
I0401 16:12:13.498] Upload result and artifacts...
I0401 16:12:13.498] Gubernator results at https://gubernator.k8s.io/build/knative-prow/pr-logs/pull/knative_docs/1122/pull-knative-docs-integration-tests/1112749193161609216
I0401 16:12:13.499] Call:  gsutil ls gs://knative-prow/pr-logs/pull/knative_docs/1122/pull-knative-docs-integration-tests/1112749193161609216/artifacts
W0401 16:12:14.520] CommandException: One or more URLs matched no objects.
E0401 16:12:14.650] Command failed```

@chaodaiG
Copy link
Contributor

chaodaiG commented Apr 1, 2019

@samodell , this is a problem happening in every knative repo right now, it's tracked here: knative/test-infra#638
And Stephen is actively working on it

@samodell
Copy link
Contributor

samodell commented Apr 1, 2019

Thanks for the info, @chaodaiG !

@samodell
Copy link
Contributor

samodell commented Apr 1, 2019

/test pull-knative-docs-integration-tests

@knative-prow-robot knative-prow-robot merged commit 350855d into knative:master Apr 1, 2019
@samodell samodell mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

@samodell samodell Awaiting requested review from samodell

Assignees

@vaikas vaikas

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nebelsprachen @samodell @knative-prow-robot @vaikas @chaodaiG @googlebot