Eventing v0.5 updates #1125
Merged
Eventing v0.5 updates #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
samodell
added
kind/eventing
kind/eventing-sources
and removed
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Harwayne
reviewed
Apr 1, 2019
knative-prow-robot
added
size/M
Contributor
Author
|
Ready for a second look, @Harwayne |
Harwayne
reviewed
Apr 2, 2019
| cluster) services, you must enable it also for them to work. | ||
| [Follow the instructions to configure outbound network access](../serving/outbound-network-access.md). | ||
|
|
||
| Install the core Knative Eventing (which provides an in-memory |
Contributor
There was a problem hiding this comment.
Why are these instructions removed? Are they now in-lined in "Fllow the instructions to install on the platform of your choice"?
Contributor
Author
There was a problem hiding this comment.
Yep, the install guides cover install steps for all the components (Eventing included). There's no reason to repeat the content on this page.
Contributor
|
/lgtm |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1020