Skip to content

Conversation

@RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Apr 2, 2019

Delete the old landing page (from Docsy template) and instead use override: knative/website#21

@RichieEscarez RichieEscarez added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 2, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved labels Apr 2, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rgregg, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,rgregg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rgregg
Copy link
Contributor

rgregg commented Apr 2, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@RichieEscarez RichieEscarez removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@RichieEscarez RichieEscarez changed the title [WIP] delete old version of site landing page Delete old version of site landing page Apr 2, 2019
@knative-prow-robot knative-prow-robot merged commit d304cc7 into knative:master Apr 2, 2019
@RichieEscarez RichieEscarez deleted the oldlanding branch April 12, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants