Skip to content

Update custom install docs for eventing #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2019
Merged

Update custom install docs for eventing #1342

merged 2 commits into from
May 17, 2019

Conversation

@grantr
Copy link
Contributor

@grantr grantr commented May 17, 2019 •
edited
Loading

Proposed Changes

  • Remove warning about Gloo/eventing incompatibility.
  • Update table of eventing and eventing-sources components in custom install instructions.

grantr added 2 commits May 17, 2019 10:22
@grantr
Eventing doesn't care about Gloo or Istio
e8d9697
@grantr
Update eventing and eventing-sources release artifacts
565faa2 
Eventing no longer requires Serving, and there are more channels and
sources now.
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 17, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2019
@grantr grantr changed the title Update install docs eventing Update install docs for eventing May 17, 2019
@grantr grantr force-pushed the update-install-docs-eventing branch from 2d69a28 to 565faa2 Compare May 17, 2019 19:03
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2019
@grantr grantr marked this pull request as ready for review May 17, 2019 19:04
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2019
@grantr grantr changed the title Update install docs for eventing Update custom install docs for eventing May 17, 2019
@samodell
Copy link
Contributor

samodell commented May 17, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ee4deca into knative:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grantr @samodell @knative-prow-robot @googlebot