Skip to content

Conversation

@grantr
Copy link
Contributor

@grantr grantr commented May 17, 2019

Proposed Changes

  • Add section about the new Knative Serving release version label (v0.4.0+), while
    keeping the old way in a different section.
  • Add an Eventing section. The Eventing components have the release
    version label, but it's set to "devel" in 0.6.0, so we can't use it this time :(

Add section about the new Knative Serving release version label, while
keeping the old way in a different section.

Also add an Eventing section. The Eventing components have the release
version label, but it's set to "devel" in 0.6.0.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 17, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor

Thanks, @grantr !

@knative-prow-robot knative-prow-robot merged commit 750937f into knative:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants