Update cert manager on GCP example to upgrade to http by default #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
|
/lgtm Besides, I don't think we need |
Contributor
Author
|
@ZhiminXiang - I removed the redirect from the https section. |
knative-prow-robot
added
size/XXL
knative-prow-robot
added
approved
size/XS
… http section and not the https section.
Contributor
Author
|
Also - rebased the PR so that it only shows the actual commits |
Contributor
Author
|
/retest |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Thanks @mikehelmick and @ZhiminXiang ! |
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Jun 26, 2019
… http section and not the https section. (knative#1463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current documentation only has httpsRedirect set on the https endpoint itself. In order for the ingress to redirect all traffic to use https, the tls section with httpsRedirect: true needs to be on the http section as well.