Skip to content

Conversation

@trshafer
Copy link
Contributor

@trshafer trshafer commented Jun 13, 2019

that are running on a kubernetes cluster after installing knative 0.6.0.

Proposed Changes

  • Describes the running knative services and deployments.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 13, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2019
that are running on a kubernetes cluster after installing knative 0.6.0.
@samodell samodell self-assigned this Jun 13, 2019
@samodell
Copy link
Contributor

Thanks for opening this PR, @trshafer ! Can you ping me when you're ready for a review?

@trshafer
Copy link
Contributor Author

Hey @samodell, thanks, it is ready. I worked with @tcnghia on the content of each service/deployment. Another option is to add Readme.md files in the directories of https://github.com/knative/serving/tree/master/cmd

@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, trshafer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6bbafd5 into knative:master Jun 25, 2019
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
…native#1467)

that are running on a kubernetes cluster after installing knative 0.6.0.
@trshafer trshafer deleted the knative-services branch July 15, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants