Skip to content

Initial additions for minScale and maxScale annotations #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2019
Merged

Initial additions for minScale and maxScale annotations #1468

merged 4 commits into from
Jun 25, 2019

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jun 14, 2019

Fixes #1331

Proposed Changes

  • added config details for minScale
  • added config details for maxScale

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 14, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2019
@abrennan89
Copy link
Contributor Author

abrennan89 commented Jun 17, 2019

/assign abrennan89

markusthoemmes
markusthoemmes reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato 🎉 . Only left a few nits.

@googlebot
Copy link

googlebot commented Jun 21, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 21, 2019
@googlebot
Copy link

googlebot commented Jun 21, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 21, 2019
@samodell
Copy link
Contributor

samodell commented Jun 25, 2019

One small tweak; then we can get this merged in, @abrennan89 !

samodell
samodell reviewed Jun 25, 2019
View reviewed changes
@samodell
Copy link
Contributor

samodell commented Jun 25, 2019

Thanks @abrennan89 !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 45f7861 into knative:master Jun 25, 2019
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
@abrennan89 @RichieEscarez
Initial additions for minScale and maxScale annotations (knative#1468)
8af5b54 
* Initial additions for minScale and maxScale annotations

* minor corrections from feedback and updated information about configuring HPA

* minor updates

* updated link to blog
@abrennan89 abrennan89 deleted the 1331 branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

2 more reviewers

@markusthoemmes markusthoemmes markusthoemmes left review comments

@samodell samodell samodell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@samodell samodell

@abrennan89 abrennan89

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No docs on minScale/maxScale features

5 participants

@abrennan89 @googlebot @samodell @knative-prow-robot @markusthoemmes