Skip to content

Conversation

@chizhg
Copy link
Contributor

@chizhg chizhg commented Jun 21, 2019

Proposed Changes

As part of fix for knative/eventing#1395.

/cc @samodell

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 21, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fredy-Z, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chizhg
Copy link
Contributor Author

chizhg commented Jun 21, 2019

/retest

1 similar comment
@chizhg
Copy link
Contributor Author

chizhg commented Jun 22, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit bcf6726 into knative:master Jun 22, 2019
@chizhg chizhg deleted the FixBrokerTriggerDemo branch June 25, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants