Content and Formatting Changes to Knative Kubernetes Services (#1522) #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
samodell
requested review from
samodell
and removed request for
carieshmarie and
gyliu513
samodell
suggested changes
Jun 28, 2019
Contributor
samodell
left a comment
samodell
left a comment
There was a problem hiding this comment.
Great start, @kzjackson1 ! Thanks for taking this on.
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
samodell
reviewed
Jun 28, 2019
samodell
suggested changes
Jun 28, 2019
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
samodell
reviewed
Jun 28, 2019
Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
Contributor
|
/lgtm Thanks, @kzjackson1 ! |
knative-prow-robot
added
lgtm
samodell
approved these changes
Jun 28, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kzjackson1, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
samodell
added a commit
to samodell/docs
that referenced
this pull request
Jun 28, 2019
…e#1522) (knative#1536) * Document edit for issue 1522 * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Addressing review comments for issue 1522 * Addressing review comments for issue 1522 * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Jun 28, 2019
* Content and Formatting Changes to Knative Kubernetes Services (#1522) (#1536) * Document edit for issue 1522 * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Addressing review comments for issue 1522 * Addressing review comments for issue 1522 * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * Update docs/serving/knative-kubernetes-services.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> * add _index.md to sequences (#1543) * remove kubectl get pods for eventing sources (#1557) * New07api (#1558) * new 07 API with eventing-contrib * manually fix HTML links and dup pkgs * update readme to mention manual updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1522
Proposed Changes