Skip to content

Conversation

@meteatamel
Copy link
Contributor

When you install the default Knative 0.7, nothing gets installed under knative-sources namespace. So, removing the check for pods under this namespace.

Fixes #issue-number

Proposed Changes

When you install the default Knative 0.7, nothing gets installed under knative-sources namespace. So, removing the check for pods under this namespace.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: meteatamel
To complete the pull request process, please assign mattmoor
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2019
@knative-prow-robot
Copy link
Contributor

Hi @meteatamel. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2019
@samodell
Copy link
Contributor

@meteatamel Good catch! That line exists in a number of other install files; would you be willing to delete it from those as well?

@samodell
Copy link
Contributor

samodell commented Jun 28, 2019

I wanted to get this change in quickly, so I opened PR #1557 . Thanks for pointing this out!

@samodell samodell closed this Jun 28, 2019
@emilkje emilkje mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants