Skip to content

Conversation

@vagababov
Copy link
Contributor

We definitely need more data there and document with more examples.
But this is for another PR.

/assign @samodell @RichieEscarez

We definitely need more data there and document with more examples.
But this is for another PR.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 27, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2019
@vagababov
Copy link
Contributor Author

PIng?

@samodell
Copy link
Contributor

samodell commented Sep 3, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6ce457c into knative:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants