-
Notifications
You must be signed in to change notification settings - Fork 1.3k
samples/grpc-ping-go: align with knative sample and README practices #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you are willing, it would be nice to update the description of this sample: "A simple gRPC server written in Go that you can use for testing." |
|
Updates address additional README improvements. |
averikitsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look great. Thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: averikitsch, grayside The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Proposed Changes
0.0.0.0instead oflocalhost.Testing Status