Skip to content

Conversation

@grayside
Copy link
Contributor

@grayside grayside commented Aug 30, 2019

Proposed Changes

  • Server listens on 0.0.0.0 instead of localhost.
  • Dockerfile and README should run and document all commands from the context of the sample as working directory.
  • Comment cleanup in Dockerfile.
  • README cleanup to improve clarity and alignment with other sample READMEs

Testing Status

  • Container builds & runs locally, but I could not adapt instructions for local testing.
  • Locally-build container deploys to Cloud Run on GKE via kubectl apply
  • Running gRPC service successfully tested with README instructions.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2019
@averikitsch
Copy link
Contributor

If you are willing, it would be nice to update the description of this sample: "A simple gRPC server written in Go that you can use for testing."
It might be nice to give a blurb about grpc and the different components of this sample (server, client). Also why do we say "that you can use for testing."?

@grayside
Copy link
Contributor Author

grayside commented Sep 3, 2019

Updates address additional README improvements.

Copy link
Contributor

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look great. Thanks!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: averikitsch, grayside

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@averikitsch
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@knative-prow-robot knative-prow-robot merged commit ea29845 into knative:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants