Skip to content

Conversation

@akashrv
Copy link
Contributor

@akashrv akashrv commented Aug 30, 2019

Fixes #issue-number

Proposed Changes

  • Added a link to a more realistic sample using Knative eventing and serving.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2019
@akashrv
Copy link
Contributor Author

akashrv commented Aug 30, 2019

/assign @samodell

@sebgoa
Copy link
Contributor

sebgoa commented Sep 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@dgerd
Copy link

dgerd commented Sep 5, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashrv, dgerd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 499af88 into knative:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants