Skip to content

Conversation

@akashrv
Copy link
Contributor

@akashrv akashrv commented Oct 4, 2019

Proposed Changes

Created Helloworld-Go for Knative Eventing.
Will send more PRs with other languages or create issues such that folks can replicate this same code in other languages.

We have heard this painpoint from multiple avenues including pilot customers that they do not know how to write an app that can consume a cloud event. This example is supposed to solve that painpoint.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 4, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 4, 2019
@akashrv
Copy link
Contributor Author

akashrv commented Oct 4, 2019

/assign @vaikas-google

@vaikas
Copy link
Contributor

vaikas commented Oct 23, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashrv, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7ed1973 into knative:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants