Correct image path in sample of "kubernetes-event-source"

[vincent-pli]

Fixes #issue-number

Proposed Changes

The original image path is not work, will make the Revision failed and raise container missing error.

[knative-prow-robot]

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vaikas]

I think this should actually be s/eventing-sources/eventing-contrib/

[RichieEscarez]

Suggested change

	image: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display
	image: gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display

[RichieEscarez]

Suggested change

	image: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display
	image: gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display

[vincent-pli]

Thanks for comments, fixed according the comments.

Actually the image: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display also could work, I get this url in another samples:
https://github.com/knative/docs/blob/master/docs/eventing/samples/sequence/sequence-reply-to-event-display/event-display.yaml

Do we need to fix that one to make consistent？

[RichieEscarez]

Thanks for comments, fixed according the comments.

Actually the image: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display also could work, I get this url in another samples:
https://github.com/knative/docs/blob/master/docs/eventing/samples/sequence/sequence-reply-to-event-display/event-display.yaml

Do we need to fix that one to make consistent？

Yes we should. I believe that URL only works because it was left up and available to avoid breaking the past docs. Now that "eventing-sources" repo has gone away and renamed to "eventing-contrib" we should only use "eventing-contrib" going forward. Thanks @vincent-pli

[vincent-pli]

@RichieEscarez
Thanks for clarification, I search the repo, there are a dozen of these mistakes, will we change them all?

[RichieEscarez]

@n3wscott can you help confirm that all the gcr.io URLs can simply be updated to /eventing-contrib/? There are 22 instances of "eventing-sources" in our repo.

[samodell]

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment