Skip to content

helloworld: go clarity tweaks and go modules for shell #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

helloworld: go clarity tweaks and go modules for shell #1908

merged 2 commits into from
Oct 21, 2019

Conversation

@grayside
Copy link
Contributor

@grayside grayside commented Oct 16, 2019

This is another step towards #1686

Proposed Changes

  • Minor clarity and log output improvements to helloworld-go
  • Update the go pieces of helloworld-shell to align with helloworld-go

Quality & Risk Assessment

  • I tested these changes locally.
  • I do not anticipate any platform-specific impacts from these changes.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 16, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2019
@RichieEscarez RichieEscarez added approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Oct 21, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: grayside

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 81bc837 into knative:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samodell samodell Awaiting requested review from samodell

@steuhs steuhs Awaiting requested review from steuhs

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grayside @knative-prow-robot @googlebot @RichieEscarez