Use cpu metric for CPU-based autoscaling sample #1918
Conversation
Using `autoscaling.knative.dev/metric: concurrency` made no sense to me so I'm doing a quick PR. An example of this can be found at https://medium.com/@mchmarny_google/https-medium-com-p-knative-autoscaling-love-story-e32a27b7855 but let's not try to send people to external links to find how to do this.
knative-prow-robot
added
the
size/XS
|
FYI: There is a copy of that blog post on our site too: https://knative.dev/blog/2019/03/27/knative-v0.3-autoscaling-a-love-story/ |
RichieEscarez
left a comment
RichieEscarez
left a comment
There was a problem hiding this comment.
@mattmoor can you please provide the LTGM?
/approve
|
Not sure why it makes no sense to scale on concurrent requests? |
|
@mattmoor because that's what the rest of the doc already does (and what KPA does by default). This section explains CPU-based autoscaling, but doesn't show how to do it at all. Finding out the string |
|
🤦♂ yeah, viewing the whole file that's pretty clear. thanks for the change! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, mattmoor, RichieEscarez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Using
autoscaling.knative.dev/metric: concurrencymade no sense to me so I'm doing a quick PR.
An example of this can be found at https://medium.com/@mchmarny_google/https-medium-com-p-knative-autoscaling-love-story-e32a27b7855
but let's not try to send people to external links to find how to do this.