Skip to content

Conversation

@RichieEscarez
Copy link
Contributor

prevent publishing the wrong URLs for each release and use the {{< branch >}} Hugo shortcode to dynamically populate the URL with the correct branch/release during docs build time

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 30, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved labels Oct 30, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d46de88 into knative:master Oct 31, 2019
@RichieEscarez RichieEscarez deleted the fixhardcodedurls branch November 18, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants