Skip to content

Conversation

@abrennan89
Copy link
Contributor

Proposed Changes

  • Added Creating Knative Services section

@RichieEscarez this should replace some of the work previously done in #1972 - I think there was some confusion about that PR because the scope wasn't necessarily supposed to be creating a service so much as collecting all the information about services and organizing it.

This new section should be inline with the plans in the nav doc though, I will address the other sections related to services (e.g. cluster local) in subsequent PRs so that I can keep the scope smaller and avoid confusion.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 14, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2019
Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, Ashleigh! Some feedback for you


> Note: If you’re deploying an image of your own app, update the name of the app and the URL of the image accordingly.

## Modifying Knative Services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section doesn't show how to make an update to a Service, but it would be great to demo that.

Copy link
Contributor

@nak3 nak3 Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various example, if we want to demo how to update Label, we can write it like this:


For example, you can add a label to a Knative Service in the same way as Kubernetes resources.

$ kubectl label ksvc hello-example example=demo-label

Then, the label example=demo-label is copied to Route and Configuration automatically.

$ kubectl get ksvc,rt,config --show-labels
NAME                                        URL                                               LATESTCREATED           LATESTREADY             READY   REASON   LABELS
service.serving.knative.dev/hello-example   http://hello-example.default.example.com   hello-example-hlplq-1   hello-example-hlplq-1   True             example=demo-label

NAME                                      URL                                               READY   REASON   LABELS
route.serving.knative.dev/hello-example   http://hello-example.default.example.com   True             example=demo-label,serving.knative.dev/service=hello-example

NAME                                              LATESTCREATED           LATESTREADY             READY   REASON   LABELS
configuration.serving.knative.dev/hello-example   hello-example-hlplq-1   hello-example-hlplq-1   True             example=demo-label,serving.knative.dev/route=hello-example,serving.knative.dev/service=hello-example

@samodell samodell removed the request for review from gyliu513 November 19, 2019 05:37
@samodell samodell self-assigned this Nov 19, 2019
@abrennan89
Copy link
Contributor Author

Hi @samodell 🙂
I've implemented all of the feedback now except for the request to doc 'updating a Service'.
@markusthoemmes can you provide details if we wanted to add this?
I think updating can be covered in a separate PR though since this once is just for creating Services.
Wdyt?

@samodell
Copy link
Contributor

/lgtm
/approve

Thanks, Ashleigh!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 51bec18 into knative:master Nov 20, 2019
@abrennan89 abrennan89 deleted the services branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants