-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added 'Creating Knative Services' section #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
samodell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Ashleigh! Some feedback for you
|
|
||
| > Note: If you’re deploying an image of your own app, update the name of the app and the URL of the image accordingly. | ||
|
|
||
| ## Modifying Knative Services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section doesn't show how to make an update to a Service, but it would be great to demo that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are various example, if we want to demo how to update Label, we can write it like this:
For example, you can add a label to a Knative Service in the same way as Kubernetes resources.
$ kubectl label ksvc hello-example example=demo-label
Then, the label example=demo-label is copied to Route and Configuration automatically.
$ kubectl get ksvc,rt,config --show-labels
NAME URL LATESTCREATED LATESTREADY READY REASON LABELS
service.serving.knative.dev/hello-example http://hello-example.default.example.com hello-example-hlplq-1 hello-example-hlplq-1 True example=demo-label
NAME URL READY REASON LABELS
route.serving.knative.dev/hello-example http://hello-example.default.example.com True example=demo-label,serving.knative.dev/service=hello-example
NAME LATESTCREATED LATESTREADY READY REASON LABELS
configuration.serving.knative.dev/hello-example hello-example-hlplq-1 hello-example-hlplq-1 True example=demo-label,serving.knative.dev/route=hello-example,serving.knative.dev/service=hello-example
|
Hi @samodell 🙂 |
|
/lgtm Thanks, Ashleigh! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
@RichieEscarez this should replace some of the work previously done in #1972 - I think there was some confusion about that PR because the scope wasn't necessarily supposed to be creating a service so much as collecting all the information about services and organizing it.
This new section should be inline with the plans in the nav doc though, I will address the other sections related to services (e.g. cluster local) in subsequent PRs so that I can keep the scope smaller and avoid confusion.