Skip to content

Updating PubSub example due to change in Destination #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

Updating PubSub example due to change in Destination #1993

merged 1 commit into from
Dec 2, 2019

Conversation

@nachocano
Copy link
Contributor

@nachocano nachocano commented Nov 20, 2019

Proposed Changes

  • Updating PubSub example due to change in Destination

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 20, 2019
@nachocano
Copy link
Contributor Author

nachocano commented Nov 20, 2019

/assign @samodell

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2019
@nachocano nachocano mentioned this pull request Nov 20, 2019
Merged
@nachocano
Copy link
Contributor Author

nachocano commented Nov 26, 2019

@samodell friendly ping

RichieEscarez
RichieEscarez approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4138465 into knative:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samodell samodell Awaiting requested review from samodell

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nachocano @knative-prow-robot @RichieEscarez @googlebot @samodell