Skip to content

Removing old versions from docs #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 2, 2019
Merged

Removing old versions from docs #1995

merged 6 commits into from
Dec 2, 2019

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Nov 21, 2019

Fixes #1850

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 21, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2019
RichieEscarez
RichieEscarez reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the great work @abrennan89 !

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2019
RichieEscarez
RichieEscarez reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment (re: Microk8s version?) and its not clear whats happening with "docs/install/Knative-with-OpenShift.md". Im not sure why its listed as a changed file but with "No changes" (strange)?

@abrennan89
Copy link
Contributor Author

abrennan89 commented Nov 22, 2019

Hi @RichieEscarez. The OpenShift docs were removed some time ago when I replaced them with a link to our product docs. For some reason this file was hanging around but it was blank, so I just deleted it? Definitely strange though.
Is there someone who can confirm the MicroK8s thing?

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Nov 25, 2019 •
edited
Loading

Is there someone who can confirm the MicroK8s thing?

I would try finding the file's author through it's commit history.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 2, 2019

@abrennan89: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check e356328 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

RichieEscarez
RichieEscarez approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking all these down and fixing these outdated version references!

I also fixed the "Creating services" frontmatter here too since the Services section was add (Turns out that "weight" in the frontmatter is also required (i guess ive never tried without it before)).

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3138186 into knative:master Dec 2, 2019
@abrennan89 abrennan89 deleted the 1850 branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samodell samodell Awaiting requested review from samodell

2 more reviewers

@ammarn911 ammarn911 ammarn911 left review comments

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove mention of all past versions

5 participants

@abrennan89 @RichieEscarez @knative-prow-robot @ammarn911 @googlebot