Update Custom Knative Installation page #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgerd
commented
Nov 26, 2019
dgerd
commented
- Reduce verbosity
- Remove reference to closed issues
- Remove reference to Knative Serving 0.3 upgrades
- Use bash variable syntax in code snippets
* Reduce verbosity * Remove reference to closed issues * Remove reference to Knative Serving 0.3 upgrades * Use bash variable syntax in code snippets
knative-prow-robot
added
approved
size/M
RichieEscarez
approved these changes
Dec 2, 2019
Contributor
RichieEscarez
left a comment
RichieEscarez
left a comment
There was a problem hiding this comment.
@dgerd if you are happy with my edit, I think this is ready to merge.
Contributor
|
FYI, I will commit one or two more changes to try and fix some funny rendering thats happening on the site: https://5de58052cff279fc5bf6e353--knative.netlify.com/docs/install/knative-custom-install/#installing-knative |
knative-prow-robot
added
size/L
Author
|
I am good with it! |
zouyee
approved these changes
Dec 3, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, RichieEscarez, zouyee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.