Skip to content

Correct typo #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2019
Merged

Correct typo #2015

merged 2 commits into from
Dec 2, 2019

Conversation

@gliptak
Copy link
Contributor

@gliptak gliptak commented Dec 2, 2019

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2019
@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 2, 2019

Hi @gliptak. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gliptak
Copy link
Contributor Author

gliptak commented Dec 2, 2019

/assign @rgregg

RichieEscarez
RichieEscarez approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez RichieEscarez removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2019
@knative-prow-robot knative-prow-robot merged commit 399aa7f into knative:master Dec 2, 2019
@gliptak gliptak deleted the patch-1 branch December 2, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rgregg rgregg

@RichieEscarez RichieEscarez

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gliptak @knative-prow-robot @RichieEscarez @rgregg @googlebot