Use the new api group for SinkBinding.

[n3wscott]

Pending on knative/eventing#2369

Related to knative/eventing#1500

Proposed Changes

• SinkBinding is moving the ApiGroup it lives in: sources.eventing.knative.dev becomes sources.knative.dev.

[matzew]

I have tested this, but I am getting this in the log of the KSVC:

{"level":"error","ts":1578909936.6494238,"logger":"fallback","caller":"http/transport.go:408","msg":"failed to decode message","error":"unknown encoding","stacktrace":"github.com/knative/eventing-contrib/vendor/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http.(*Transport).ServeHTTP\n\t/home/prow/go/src/github.com/knative/eventing-contrib/vendor/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http/transport.go:408\nnet/http.(*ServeMux).ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2375\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2774\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:1878"}

But I do see various hearbeat jobs:

heartbeat-cron-1578909900-sm467                  0/1     Completed   0          103s
heartbeat-cron-1578909960-27f5z                  0/1     Completed   0          43s

[matzew]

using a different logger, than the one in the example, I am getting:

2020/01/13 10:10:10 failed to decode message: unknown encoding for message &{map[Accept-Encoding:[gzip] Ce-Beats:[true] Ce-Heart:[yes] Ce-Id:[203180ca-a891-4201-90b8-190098152aef] Ce-Source:[https://knative.dev/eventing-contrib/cmd/heartbeats/#default/heartbeat-cron-1578910200-wpggt] Ce-Specversion:[1.0] Ce-The:[42] Ce-Time:[2020-01-13T10:10:10.230226174Z] Ce-Type:[dev.knative.eventing.samples.heartbeat] Content-Length:[19] Forwarded:[for=10.130.6.4;proto=http, for=10.130.12.4] K-Proxy-Request:[activator] User-Agent:[Go-http-client/1.1] X-B3-Sampled:[0] X-B3-Spanid:[45a0044e702f8925] X-B3-Traceid:[94eb34a049671f8b45a0044e702f8925] X-Envoy-Decorator-Operation:[event-display-5sssm.default.svc.cluster.local:80/*] X-Envoy-Expected-Rq-Timeout-Ms:[600000] X-Envoy-Internal:[true] X-Forwarded-For:[10.130.6.4, 10.130.12.4, 10.129.14.4] X-Forwarded-Proto:[http] X-Request-Id:[56de5faa-c788-4216-a862-dfc866499cb6]] [123 34 105 100 34 58 49 44 34 108 97 98 101 108 34 58 34 34 125]} &{POST / HTTP/1.1 1 1 map[Accept-Encoding:[gzip] Ce-Beats:[true] Ce-Heart:[yes] Ce-Id:[203180ca-a891-4201-90b8-190098152aef] Ce-Source:[https://knative.dev/eventing-contrib/cmd/heartbeats/#default/heartbeat-cron-1578910200-wpggt] Ce-Specversion:[1.0] Ce-The:[42] Ce-Time:[2020-01-13T10:10:10.230226174Z] Ce-Type:[dev.knative.eventing.samples.heartbeat] Content-Length:[19] Forwarded:[for=10.130.6.4;proto=http, for=10.130.12.4] K-Proxy-Request:[activator] User-Agent:[Go-http-client/1.1] X-B3-Sampled:[0] X-B3-Spanid:[45a0044e702f8925] X-B3-Traceid:[94eb34a049671f8b45a0044e702f8925] X-Envoy-Decorator-Operation:[event-display-5sssm.default.svc.cluster.local:80/*] X-Envoy-Expected-Rq-Timeout-Ms:[600000] X-Envoy-Internal:[true] X-Forwarded-For:[10.130.6.4, 10.130.12.4, 10.129.14.4] X-Forwarded-Proto:[http] X-Request-Id:[56de5faa-c788-4216-a862-dfc866499cb6]] 0xc0000f2240 <nil> 19 [] false event-display.default.svc.cluster.local map[] map[] <nil> map[] 127.0.0.1:56846 / <nil> <nil> <nil> 0xc0000f2280}

So... the binding works... stuff is delivered ... but the "consuming client" seems to have issues ...

[samodell]

@n3wscott Currently holding off merging due to Matzew's comments.

[n3wscott]

Those errors are unrelated to this change. I think there is an issue in the event display app.

[samodell]

thanks!
/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment