-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Gardener to vendors list #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Welcome @shturec! It looks like this is your first PR to knative/docs 🎉 |
|
Hi @shturec. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
8c3c311 to
069f7ab
Compare
fd59fdb to
24c22a6
Compare
24c22a6 to
a0b3cd4
Compare
|
Hi @shturec 🙂 is this still WIP? |
Just removed the WIP. Go ahead :-) |
|
/assign @rgregg |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rgregg, shturec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Migration of the guide for installing knative on Gardener in response to the notification for repurposing the installation guide
Fixes the offerings section after migration of the guide to a Gardener-hosted location.
Proposed Changes