Skip to content

Conversation

@shturec
Copy link
Contributor

@shturec shturec commented Feb 21, 2020

Migration of the guide for installing knative on Gardener in response to the notification for repurposing the installation guide

Fixes the offerings section after migration of the guide to a Gardener-hosted location.

Proposed Changes

  • Add a bullet with a link to the new location of the guide in the knative-offerings section

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Feb 21, 2020
@knative-prow-robot
Copy link
Contributor

Welcome @shturec! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot
Copy link
Contributor

Hi @shturec. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2020
@shturec
Copy link
Contributor Author

shturec commented Feb 21, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Feb 21, 2020
@shturec shturec force-pushed the vendors-gardener branch 3 times, most recently from fd59fdb to 24c22a6 Compare February 22, 2020 13:36
@abrennan89
Copy link
Contributor

Hi @shturec 🙂 is this still WIP?

@shturec shturec changed the title [WIP] Add Gardener to vendors list Add Gardener to vendors list Feb 25, 2020
@shturec
Copy link
Contributor Author

shturec commented Feb 25, 2020

Hi @shturec 🙂 is this still WIP?

Just removed the WIP. Go ahead :-)

@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2020
@shturec
Copy link
Contributor Author

shturec commented Feb 29, 2020

/assign @rgregg

@rgregg
Copy link
Contributor

rgregg commented Feb 29, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 29, 2020
@rgregg
Copy link
Contributor

rgregg commented Feb 29, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2020
@rgregg
Copy link
Contributor

rgregg commented Feb 29, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rgregg, shturec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 11b88c3 into knative:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants