Skip to content

add triggermesh to the list of knative offerings #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

add triggermesh to the list of knative offerings #2235

merged 1 commit into from
Feb 25, 2020

Conversation

@sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Feb 23, 2020

Proposed Changes

  • Adds triggermesh cloud to the list of knative-offerigns

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 23, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2020
abrennan89
abrennan89 previously requested changes Feb 24, 2020
View reviewed changes
@abrennan89 abrennan89 dismissed their stale review February 25, 2020 16:04

I'll put in another PR to make the language consistent

abrennan89
abrennan89 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@abrennan89 abrennan89 removed the request for review from RichieEscarez February 25, 2020 16:06
@abrennan89
Copy link
Contributor

abrennan89 commented Feb 25, 2020

/approve

@abrennan89
Copy link
Contributor

abrennan89 commented Feb 25, 2020

@carieshmarie Sam is on leave now so please advise who can add an approved label to allow this to merge

@abrennan89 abrennan89 added this to the 0.13.x milestone Feb 25, 2020
mattmoor
mattmoor reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, mattmoor, sebgoa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 573eef1 into knative:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carieshmarie carieshmarie

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

0.13.x

Development

Successfully merging this pull request may close these issues.

6 participants

@sebgoa @abrennan89 @knative-prow-robot @mattmoor @googlebot @carieshmarie