Skip to content

Switch support status for triggermesh external sources #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

Switch support status for triggermesh external sources #2236

merged 1 commit into from
Apr 13, 2020

Conversation

@sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Feb 23, 2020

Proposed Changes

  • Switch the status of TriggerMesh external sources to "supported" since we now offer support.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 23, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2020
@sebgoa
Copy link
Contributor Author

sebgoa commented Mar 5, 2020

/test pull-knative-docs-markdown-link-check

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 5, 2020

@sebgoa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check 2ebb1a4 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebgoa
Copy link
Contributor Author

sebgoa commented Mar 5, 2020

The error does not seem related to this PR.

evankanderson
evankanderson reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, sebgoa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 56fbb6a into knative:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@evankanderson evankanderson

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebgoa @knative-prow-robot @evankanderson @googlebot