Skip to content

Conversation

@lionelvillard
Copy link
Contributor

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

  • update parallel doc to v1beta1

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 3, 2020
@lionelvillard
Copy link
Contributor Author

depends on #2126

@lionelvillard
Copy link
Contributor Author

/assign @vaikas

@n3wscott
Copy link
Contributor

n3wscott commented Mar 4, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@xlight05
Copy link

xlight05 commented Mar 7, 2020

Change in docker image of event_display is crucial because the current doc points to the wrong docker image and its not working. We need this live asap

@matzew
Copy link
Member

matzew commented Mar 9, 2020

/test pull-knative-docs-markdown-link-check

@matzew
Copy link
Member

matzew commented Mar 9, 2020

/lgtm

@matzew
Copy link
Member

matzew commented Mar 9, 2020

/approve

1 similar comment
@lionelvillard
Copy link
Contributor Author

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5137c7f into knative:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants