Skip to content

Eventing API docs for v0.13.0 #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2020
Merged

Eventing API docs for v0.13.0 #2268

merged 3 commits into from
Mar 4, 2020

Conversation

@ellenevans
Copy link
Contributor

@ellenevans ellenevans commented Mar 4, 2020

Updates to Eventing API docs for v0.13.0

  • eventing-contrib.md
  • eventing.md

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 4, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 4, 2020
@ellenevans @mattmoor
Update docs/reference/eventing/eventing-contrib.md
f55cb4b 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@ellenevans
Copy link
Contributor Author

ellenevans commented Mar 4, 2020

/retest

1 similar comment
@ellenevans
Copy link
Contributor Author

ellenevans commented Mar 4, 2020

/retest

@ellenevans
Copy link
Contributor Author

ellenevans commented Mar 4, 2020

The link is fine.

@ellenevans
Copy link
Contributor Author

ellenevans commented Mar 4, 2020

/test pull-knative-docs-markdown-link-check

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 4, 2020

@ellenevans: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check f55cb4b link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RichieEscarez RichieEscarez added approved lgtm Indicates that a PR is ready to be merged. labels Mar 4, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ellenevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2b5a388 into knative:master Mar 4, 2020
@lberk lberk mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrennan89 abrennan89 Awaiting requested review from abrennan89

@samodell samodell Awaiting requested review from samodell

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ellenevans @knative-prow-robot @mattmoor @googlebot @RichieEscarez